Fixed reference searches related to JsxNamespacedName#62124
Open
Andarist wants to merge 5 commits intomicrosoft:mainfrom
Open
Fixed reference searches related to JsxNamespacedName#62124Andarist wants to merge 5 commits intomicrosoft:mainfrom
JsxNamespacedName#62124Andarist wants to merge 5 commits intomicrosoft:mainfrom
Conversation
typescript-bot
added
the
For Uncommitted Bug
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes reference searches for JSX namespaced names (e.g., prop:foo in JSX attributes) by addressing issues where find all references and rename operations weren't working correctly for these syntax elements.
- Updates reference and rename functionality to properly handle JSX namespaced names
- Adds support for JSX namespaced names in name table initialization and node eligibility checks
- Includes comprehensive test cases with baseline expectations for both rename and find all references operations
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
tests/cases/fourslash/renameOnJsxNamespacedName1.ts |
Test case for rename functionality on JSX namespaced names |
tests/cases/fourslash/findAllReferencesOnJsxNamespacedName1.ts |
Test case for find all references functionality on JSX namespaced names |
tests/baselines/reference/renameOnJsxNamespacedName1.baseline.jsonc |
Expected baseline output for rename test |
tests/baselines/reference/findAllReferencesOnJsxNamespacedName1.baseline.jsonc |
Expected baseline output for find all references test |
src/services/utilities.ts |
Core utility functions updated to handle JSX namespaced names in location adjustment and property name detection |
src/services/services.ts |
Name table initialization updated to include JSX namespaced names |
src/services/rename.ts |
Rename eligibility check updated to include JSX namespaced names |
src/services/findAllReferences.ts |
Find all references functionality updated with JSX namespaced name support |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #62123